[PWGLF] neutronSkin analysis task #14378
Merged
+862
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BongHwi
requested review from
alibuild,
fmazzasc,
maciacco,
mpuccio and
skundu692
as code owners
|
O2 linter results: ❌ 1 errors, |
Please consider the following formatting changes to AliceO2Group#14378
maciacco
approved these changes
Jan 3, 2026
Collaborator
Author
|
Thanks! @maciacco |
vkucera
reviewed
Jan 8, 2026
Comment on lines
+30
to
+35
| #include "CommonConstants/MathConstants.h" | ||
| #include "CommonConstants/PhysicsConstants.h" | ||
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/HistogramRegistry.h" | ||
| #include "Framework/O2DatabasePDGPlugin.h" | ||
| #include "Framework/runDataProcessing.h" |
vkucera
reviewed
Jan 8, 2026
Comment on lines
+80
to
+86
| kPt = 0, | ||
| kCentrality = 1, | ||
| kCharge = 2, | ||
| kEtaSign = 3, | ||
| kMcType = 4, | ||
| kPhi = 5, | ||
| kNAxes = 6 |
Collaborator
There was a problem hiding this comment.
The prefix k is useless and violates the naming conventions.
sigurdnese
pushed a commit
to sigurdnese/O2Physics
that referenced
this pull request
Jan 9, 2026
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relocation + optimze the task with
THnSparseApply improved
CollisionCuts