Skip to content

[O2B-1578] Change timeRange filters to only trigger filters when both time and date have been filled in#2130

Open
NarrowsProjects wants to merge 1 commit intomainfrom
improv/O2B-1578/Change-timeRange-filters-to-only-trigger-filters-when-both-time-and-date-have-been-filled-in
Open

[O2B-1578] Change timeRange filters to only trigger filters when both time and date have been filled in#2130
NarrowsProjects wants to merge 1 commit intomainfrom
improv/O2B-1578/Change-timeRange-filters-to-only-trigger-filters-when-both-time-and-date-have-been-filled-in

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 13, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Overview pages will no longer keep reloading whilst they're filling time range filters

Notable changes for developers:

  • DateTimeInputModel will only notify its observers if both time and date are provided during an update

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 13, 2026
@NarrowsProjects NarrowsProjects changed the title feat: only notify models if both time and date have been provided. [O2B-1578] Change timeRange filters to only trigger filters when both time and date have been filled in Apr 13, 2026
@NarrowsProjects NarrowsProjects added the javascript Pull requests that update Javascript code label Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.50%. Comparing base (1333378) to head (74b504a).

Files with missing lines Patch % Lines
...omponents/common/form/inputs/DateTimeInputModel.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   45.50%   45.50%   -0.01%     
==========================================
  Files        1044     1044              
  Lines       17353    17354       +1     
  Branches     3149     3151       +2     
==========================================
  Hits         7897     7897              
- Misses       9456     9457       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant