Repository navigation
DPL: do not use an attribute value the query parser failed to read - #16101
Merged
Merged
Conversation
When the value of a query attribute was empty, e.g. "x:TST/A1/0?lifetime=", assignLastStringMatch pushed the error state and returned without setting currentValue, but IN_END_VALUE went on to read *currentValue, which was unset. The DataQuery test crashed on this with GCC 15. Stop at the error, merge the three identical branches, and reset the attribute key and value for each ;-separated query like the rest of the per-query state.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for ddabeab at 2026-11-11 11:05: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the value of a query attribute was empty, e.g. "x:TST/A1/0?lifetime=",
assignLastStringMatch pushed the error state and returned without setting
currentValue, but IN_END_VALUE went on to read *currentValue, which was
unset. The DataQuery test crashed on this with GCC 15. Stop at the error,
merge the three identical branches, and reset the attribute key and value
for each ;-separated query like the rest of the per-query state.