Conversation
macOS ships OpenCL 1.2, below the 2.x the OpenCL backend requires, so find_package(OpenCL) there could never produce a usable backend: the version check dropped it again a few lines later. Skip the lookup on Apple instead. With that, CUDA_ENABLED, OPENCL_ENABLED and HIP_ENABLED are all necessarily off on macOS, which makes the Darwin arm of the backend dispatch dead code. Drop it along with its warning and unindent the rest.
Collaborator
davidrohr
approved these changes
Sep 18, 2026
Collaborator
|
Looks good, but you have to update alidist/resources/FindO2GPU.cmalke first, and raise its version in the comment at the beginning, then update the one in O2. |
Member
Author
|
@davidrohr yes, i noticed. I will take care of it. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS ships OpenCL 1.2, below the 2.x the OpenCL backend requires, so
find_package(OpenCL) there could never produce a usable backend: the version
check dropped it again a few lines later. Skip the lookup on Apple instead.
With that, CUDA_ENABLED, OPENCL_ENABLED and HIP_ENABLED are all necessarily
off on macOS, which makes the Darwin arm of the backend dispatch dead code.
Drop it along with its warning and unindent the rest.
Stack created with Sapling. Best reviewed with ReviewStack.