Skip to content

Get rid of wrapper script for creating ROOT dictionaries - #15803

Merged
ktf merged 1 commit into
AliceO2Group:devfrom
ktf:pr15803
Sep 20, 2026
Merged

ktf merged 1 commit into
AliceO2Group:devfrom
ktf:pr15803

Conversation

@ktf

@ktf ktf commented Sep 16, 2026

Copy link
Copy Markdown
Member

The sole need for the wrapper was to properly handle warnings
and complain on missing options. Since long rootcling is now gracefully
handling both, so we remove the wrapper.

@alibuild

alibuild commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 4f22e18 at 2026-09-20 08:17:

## sw/BUILD/lhapdf-latest/log
collect2: error: ld returned 1 exit status


## sw/BUILD/VecGeom-latest/log
CMake Error at /container/bits/sw/BUILD/4b902089e8ae3e1235b16cffffe5b41003a490dd/VecGeom/buildExternals/VecCore-0.8.0/build/external/stamp/VecCore-0.8.0-configure-RELWITHDEBINFO.cmake:49 (message):
ninja: build stopped: subcommand failed.
CMake Error at cmake/modules/BuiltinVecCore.cmake:36 (add_custom_command):
CMake Error at CMakeLists.txt:222 (find_package):

Full log here.

@aalkin aalkin mentioned this pull request Sep 18, 2026
@vkucera

vkucera commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

I suspect the changes alter LD_LIBRARY_PATH which misses the path to OpenSSL as a result.

Comment thread cmake/AddRootDictionary.cmake Outdated
@aalkin

aalkin commented Sep 19, 2026

Copy link
Copy Markdown
Member

I suspect the changes alter LD_LIBRARY_PATH which misses the path to OpenSSL as a result.

You are right! The environment variable is not passed correctly.

The sole need for the wrapper was to properly handle warnings
and complain on missing options. Since long rootcling is now gracefully
handling both, so we remove the wrapper.
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 73a0229 at 2026-09-20 10:08:

No log files found

Full log here.

@ktf

ktf commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

Updated with the fix for the LD_LIBRARY_PATH. Fixing CMake to have static openssl is probably the correct thing to do, though.

@ktf

ktf commented Sep 20, 2026

Copy link
Copy Markdown
Member Author

Full CI works. Merging.

@ktf
ktf merged commit c8c068f into AliceO2Group:dev Sep 20, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants