Skip to content

Remove code setter#3461

Closed
tvdeyen wants to merge 1 commit intomainfrom
remove-code-setter
Closed

Remove code setter#3461
tvdeyen wants to merge 1 commit intomainfrom
remove-code-setter

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Nov 4, 2025

What is this pull request for?

Describe you pull request here...

Closes # (Remove if not related to any issue)

Notable changes (remove if none)

Explain any changes (maybe breaking?) that have been made.

Screenshots

Remove if no visual changes have been made.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

The `code` getter returns the combination of `language_code` and `country_code`,
but is not a attribute we can or must set.
@tvdeyen tvdeyen added this to the 8.1 milestone Nov 4, 2025
@tvdeyen tvdeyen changed the base branch from main to fix-factories November 4, 2025 11:37
Base automatically changed from fix-factories to main November 4, 2025 11:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 4, 2026

This pull request has not seen any activiy in a long time.
Probably because of missing tests or a necessary rebase.
This PR will be closed in 7 days if no further activity happens.

@github-actions github-actions Bot added the Stale label Jan 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

This pull request has not seen any activiy in a long time.
Probably because of missing tests or a necessary rebase.
Please open a new PR to latest main if you want to continue working on this.
Thanks for the contribution.

@github-actions github-actions Bot closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant