fix: resolve Promise.all concurrent query collision with identical SQ…#2465
Open
imsanupm wants to merge 1 commit intoAlaSQL:developfrom
Open
fix: resolve Promise.all concurrent query collision with identical SQ…#2465imsanupm wants to merge 1 commit intoAlaSQL:developfrom
imsanupm wants to merge 1 commit intoAlaSQL:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1953
When two async functions with identical SQL strings were executed
concurrently via
Promise.all, no results were returned and no errorwas thrown.
Root Cause
Two separate issues were working together to cause this bug:
cleanupCachemutating shared cached object — The compiledstatement stored in
sqlCacheis shared across concurrent executions.cleanupCachewas clearingstatement.query.data = []on this sharedobject while another concurrent call was still reading it, silently
wiping the results.
Shared params reference — Concurrent executions via
Promise.allwere sharing the same params reference, allowing one call to overwrite
another's parameters (
f1/f2).Why it was hard to notice
fine because they got different cache keys
Promise.allChanges
cleanupCache()— Removed mutation ofstatement.query.dataon theshared cached statement object
alasql.dexec()— Clone params before passing to cached statementexecution to isolate each concurrent call's parameters
How to reproduce (before fix)
Testing
Promise.allnow return correct resultsalasql.options.cache = false) unaffected