test(sdk): align bare Claude alias test with the curated alias list#5393
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The required "12 - check unit tests" check is red on the release/v0.105.6 tip. The unit test
test_bare_claude_alias_resolves_to_anthropicinsdks/python/oss/tests/pytest/unit/agents/platform/test_connections_http.pystill iterates a bare"opus"alias, and the vault resolver derives its bare-Claude-alias acceptance from the curatedCLAUDE_MODEL_ALIASESlist, so bare"opus"now raisesMissingProviderErrorand the assertion fails.PR #5365 curated
CLAUDE_MODEL_ALIASESdown to the stable harness request values and updatedtest_capabilities.pyandtest_model_catalog.py, but missed this third test module. This change aligns the loop to the curated aliases (haiku,sonnet,opus[1m]) and updates the comment accordingly. Behavior note: a user-typed bare"opus"now needs the documentedanthropic/prefix or one of the picker's curated values, and the runner widens hinted variants. No production code changes.