Skip to content

test(sdk): align bare Claude alias test with the curated alias list#5393

Merged
mmabrouk merged 1 commit into
release/v0.105.6from
fix/release-claude-alias-test
Jul 19, 2026
Merged

test(sdk): align bare Claude alias test with the curated alias list#5393
mmabrouk merged 1 commit into
release/v0.105.6from
fix/release-claude-alias-test

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

The required "12 - check unit tests" check is red on the release/v0.105.6 tip. The unit test test_bare_claude_alias_resolves_to_anthropic in sdks/python/oss/tests/pytest/unit/agents/platform/test_connections_http.py still iterates a bare "opus" alias, and the vault resolver derives its bare-Claude-alias acceptance from the curated CLAUDE_MODEL_ALIASES list, so bare "opus" now raises MissingProviderError and the assertion fails.

PR #5365 curated CLAUDE_MODEL_ALIASES down to the stable harness request values and updated test_capabilities.py and test_model_catalog.py, but missed this third test module. This change aligns the loop to the curated aliases (haiku, sonnet, opus[1m]) and updates the comment accordingly. Behavior note: a user-typed bare "opus" now needs the documented anthropic/ prefix or one of the picker's curated values, and the runner widens hinted variants. No production code changes.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 19, 2026
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Building Building Preview, Comment Jul 19, 2026 2:16pm

Request Review

@dosubot dosubot Bot added python Pull requests that update Python code tests labels Jul 19, 2026
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f953dc2c-bff3-47bd-b798-b50793caacc2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-claude-alias-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk mmabrouk added the lgtm This PR has been approved by a maintainer label Jul 19, 2026
@mmabrouk
mmabrouk merged commit a21d057 into release/v0.105.6 Jul 19, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant