Skip to content

fix(auth): correct exc_infp typo to exc_info in auto-join error logging#5377

Merged
mmabrouk merged 1 commit into
Agenta-AI:release/v0.105.6from
truecallerabreham:fix/exc-info-typo
Jul 19, 2026
Merged

fix(auth): correct exc_infp typo to exc_info in auto-join error logging#5377
mmabrouk merged 1 commit into
Agenta-AI:release/v0.105.6from
truecallerabreham:fix/exc-info-typo

Conversation

@truecallerabreham

Copy link
Copy Markdown

Describe your changes

A one-character typo fix in the auth service: exc_infp=Trueexc_info=True.

What is the current behavior?

When an auto-join exception occurs during login, the error is logged with exc_infp=True which is not a valid parameter for log.error(). The traceback is silently dropped, making it impossible to debug auto-join failures in production.

What is the new behavior?

The correct parameter name exc_info=True ensures the full traceback is included in the error log, allowing operators to diagnose auto-join failures.

Checklist

  • I have performed a self-review of my code

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 18, 2026
@vercel

vercel Bot commented Jul 18, 2026

Copy link
Copy Markdown

@truecallerabreham is attempting to deploy a commit to the agenta projects Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot Bot added the bug Something isn't working label Jul 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @truecallerabreham, thanks for opening a pull request. 🙏

This PR was automatically closed because it does not yet meet our contribution requirements:

  • The Summary section is missing or empty. Describe what changed and why using the PR template.
  • This PR changes functional code (SDK, API, or frontend) but includes no demo. Add a screenshot or short video of the change. Only test-only, docs-only, or chore changes may skip it.

We ask for this so every change is documented and demonstrably tested before review.

How to get it reopened
Update the PR description (and add a demo recording if your change touches functional code). The bot reopens the PR automatically once the requirements are met. No need to open a new one.

See the Contributing guide and Creating your first PR. If you think this was closed in error, leave a comment and a maintainer will take a look.

@github-actions github-actions Bot added the incomplete-pr PR is missing required template sections or a demo recording label Jul 18, 2026
@github-actions github-actions Bot closed this Jul 18, 2026
@mmabrouk mmabrouk reopened this Jul 18, 2026

@mmabrouk mmabrouk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 18, 2026
@mmabrouk

Copy link
Copy Markdown
Member

@all-contributors please add @truecallerabreham for typo fix

@allcontributors

Copy link
Copy Markdown
Contributor

@mmabrouk

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The authentication auto-join error handler now uses the correct exc_info=True argument, ensuring exception trace information is included in error logs.

Changes

Authentication Logging

Layer / File(s) Summary
Correct exception trace logging
api/oss/src/core/auth/service.py
The auto-join error handler changes the misspelled exc_infp=True argument to exc_info=True.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the typo fix in auth error logging and matches the changed code.
Description check ✅ Passed The description accurately explains the logging typo fix and its effect on traceback output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk

Copy link
Copy Markdown
Member

@all-contributors please add @truecallerabreham for bug

@allcontributors

Copy link
Copy Markdown
Contributor

@mmabrouk

I've put up a pull request to add @truecallerabreham! 🎉

@mmabrouk mmabrouk reopened this Jul 19, 2026
@mmabrouk
mmabrouk merged commit 2f01eb7 into Agenta-AI:release/v0.105.6 Jul 19, 2026
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working incomplete-pr PR is missing required template sections or a demo recording lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants