fix(auth): correct exc_infp typo to exc_info in auto-join error logging#5377
Conversation
|
@truecallerabreham is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Hi @truecallerabreham, thanks for opening a pull request. 🙏 This PR was automatically closed because it does not yet meet our contribution requirements:
We ask for this so every change is documented and demonstrably tested before review. How to get it reopened See the Contributing guide and Creating your first PR. If you think this was closed in error, leave a comment and a maintainer will take a look. |
|
@all-contributors please add @truecallerabreham for typo fix |
|
I couldn't determine any contributions to add, did you specify any contributions? |
📝 WalkthroughWalkthroughThe authentication auto-join error handler now uses the correct ChangesAuthentication Logging
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@all-contributors please add @truecallerabreham for bug |
|
I've put up a pull request to add @truecallerabreham! 🎉 |
Describe your changes
A one-character typo fix in the auth service:
exc_infp=True→exc_info=True.What is the current behavior?
When an auto-join exception occurs during login, the error is logged with
exc_infp=Truewhich is not a valid parameter forlog.error(). The traceback is silently dropped, making it impossible to debug auto-join failures in production.What is the new behavior?
The correct parameter name
exc_info=Trueensures the full traceback is included in the error log, allowing operators to diagnose auto-join failures.Checklist