Skip to content

[fix] Stop the agents tables from growing past the window#5339

Open
ashrafchowdury wants to merge 5 commits into
mainfrom
fix-agents-table-layout-issue
Open

[fix] Stop the agents tables from growing past the window#5339
ashrafchowdury wants to merge 5 commits into
mainfrom
fix-agents-table-layout-issue

Conversation

@ashrafchowdury

Copy link
Copy Markdown
Contributor

Context

The agents page table grew with every row instead of fitting the window. With enough
agents the whole page scrolled and the search bar and column header scrolled out of view.

Layout.tsx derives an isFullHeight flag from the route, and only full-height routes get
the bounded h-[calc(100dvh-75px)] overflow-hidden frame that lets a table size itself to
the window. Prompts, testsets, observability, variants and the audit log are all on that
list. /agents was never added, so the table measured its own content and grew.

Changes

Add /agents to the isFullHeight route flags:

Before:
isAuditLog || isAgentTemplates

After:
isAuditLog || isAgentTemplates || isAgents

AgentsPage and ArchivedAgentsPage already pass className="grow min-h-0" and render
InfiniteVirtualTableFeatureShell with autoHeight on, so they were already asking for the
frame. grow min-h-0 is inert without a bounded parent, which is why fixing this on the page
side would not have worked. One flag covers both routes. The substring does not collide with
/agent-templates, which keeps its own flag.

The home page "Your agents" table needs the opposite treatment, also in this commit. It sits
inside a scrolling content-flow page, so it has no window-sized parent to follow. It now
bounds its virtual viewport explicitly with scroll: {y: 576}. Without that bound the table
measures its own rendered height and feeds it straight back into its own scroll viewport. The
"Created by" cell also gets shrink-0 so the author label is not squeezed on a tight row.

Tests / notes

  • eslint is clean on the touched files.
  • tsc reports one pre-existing error at Layout.tsx:314 (appName passed to a component that
    does not declare it). It is unrelated to this change and predates it.
  • No automated coverage. The flag only manifests in the rendered frame, so the checks below
    are the real verification.

What to QA

  • Open /agents in a project with enough agents to overflow the viewport. The table body
    scrolls on its own, the page does not, and the search bar and column header stay put.
  • Shrink the window height. The table body shrinks with it rather than pushing the page taller.
  • /agents/archived: same behavior.
  • Home page "Your agents": the table stops at roughly 576px and scrolls internally. The page
    itself still scrolls normally.
  • Regression: /prompts, /testsets, /observability and /variants are still full height.
    They share the flag this change touched.
  • Regression: the /agent-templates gallery still renders its fixed header and card grid.

preview

Fix: table length ends with window size

image

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 19, 2026 2:34pm

Request Review

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working Frontend labels Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Agents routes now use full-height layout handling. The agents table uses a fixed virtual scroll height, and its Created by labels are prevented from shrinking.

Changes

Agents page presentation

Layer / File(s) Summary
Agents full-height layout
web/oss/src/components/Layout/Layout.tsx
Adds an /agents route flag and includes it in full-height layout selection.
Agents table viewport and labels
web/oss/src/components/pages/agent-home/components/YourAgentsTable/index.tsx, web/oss/src/components/pages/agent-home/components/YourAgentsTable/columns.tsx
Sets a fixed virtual table body height and applies shrink-0 to the Created by cell wrapper and author label.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: preventing agents tables from growing beyond the viewport.
Description check ✅ Passed The description is detailed and directly describes the agents layout and table-sizing changes in the PR.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-agents-table-layout-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Railway Preview Environment

Preview URL https://gateway-production-3791.up.railway.app/w
Project agenta-oss-pr-5339
Image tag pr-5339-1ba3e82
Status Deployed
Railway logs Open logs
Workflow logs View workflow run
Updated at 2026-07-19T15:24:22.632Z

@ardaerzin
ardaerzin self-requested a review July 17, 2026 16:10
@mmabrouk
mmabrouk changed the base branch from main to release/v0.105.6 July 19, 2026 14:05
@mmabrouk
mmabrouk changed the base branch from release/v0.105.6 to main July 19, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Frontend size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants