[fix] Stop the agents tables from growing past the window#5339
Open
ashrafchowdury wants to merge 5 commits into
Open
[fix] Stop the agents tables from growing past the window#5339ashrafchowdury wants to merge 5 commits into
ashrafchowdury wants to merge 5 commits into
Conversation
…table scroll height
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAgents routes now use full-height layout handling. The agents table uses a fixed virtual scroll height, and its Created by labels are prevented from shrinking. ChangesAgents page presentation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Railway Preview Environment
|
ardaerzin
self-requested a review
July 17, 2026 16:10
ardaerzin
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The agents page table grew with every row instead of fitting the window. With enough
agents the whole page scrolled and the search bar and column header scrolled out of view.
Layout.tsxderives anisFullHeightflag from the route, and only full-height routes getthe bounded
h-[calc(100dvh-75px)] overflow-hiddenframe that lets a table size itself tothe window. Prompts, testsets, observability, variants and the audit log are all on that
list.
/agentswas never added, so the table measured its own content and grew.Changes
Add
/agentsto theisFullHeightroute flags:Before:
isAuditLog || isAgentTemplates
After:
isAuditLog || isAgentTemplates || isAgents
AgentsPageandArchivedAgentsPagealready passclassName="grow min-h-0"and renderInfiniteVirtualTableFeatureShellwithautoHeighton, so they were already asking for theframe.
grow min-h-0is inert without a bounded parent, which is why fixing this on the pageside would not have worked. One flag covers both routes. The substring does not collide with
/agent-templates, which keeps its own flag.The home page "Your agents" table needs the opposite treatment, also in this commit. It sits
inside a scrolling content-flow page, so it has no window-sized parent to follow. It now
bounds its virtual viewport explicitly with
scroll: {y: 576}. Without that bound the tablemeasures its own rendered height and feeds it straight back into its own scroll viewport. The
"Created by" cell also gets
shrink-0so the author label is not squeezed on a tight row.Tests / notes
Layout.tsx:314(appNamepassed to a component thatdoes not declare it). It is unrelated to this change and predates it.
are the real verification.
What to QA
/agentsin a project with enough agents to overflow the viewport. The table bodyscrolls on its own, the page does not, and the search bar and column header stay put.
/agents/archived: same behavior.itself still scrolls normally.
/prompts,/testsets,/observabilityand/variantsare still full height.They share the flag this change touched.
/agent-templatesgallery still renders its fixed header and card grid.preview
Fix: table length ends with window size