Avoid Gson final-field mutation on modern JDKs - #2031
Open
gregjotau wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2030.
Make the Gson-serialized
adyenLibraryfield non-final. Gson already mutates this field during deserialization; on JDK 26 that reflective write emits a final-field mutation warning and is scheduled to require explicit opt-in under JEP 500.The public API remains read-only because no setter is added, and the constructor continues to initialize the SDK name/version.
Verification:
mvn -Dtest=SaleToAcquirerDataSerializerTest test— round trip passes and the final-field warning is gone.mvn test -DskipITs— 617 tests, 0 failures/errors, 4 skips on JDK 26.