Skip to content

Make Swagger annotation dependencies optional - #2029

Open
gregjotau wants to merge 1 commit into
Adyen:mainfrom
gregjotau:build/optional-swagger-annotations
Open

Make Swagger annotation dependencies optional#2029
gregjotau wants to merge 1 commit into
Adyen:mainfrom
gregjotau:build/optional-swagger-annotations

Conversation

@gregjotau

Copy link
Copy Markdown
Contributor

Fixes #2028.

Mark the Swagger v1 and v3 annotation artifacts as optional. The SDK still compiles with both dependencies, while applications that only use Adyen APIs no longer receive documentation metadata transitively or collide with Jakarta Swagger annotations. Consumers that reflect on Adyen model annotations can declare the relevant artifact explicitly.

Verification:

  • mvn test -DskipITs — 617 tests, 0 failures/errors, 4 skips on JDK 26.
  • A Spring Boot 4/Kotlin consumer compiles its Adyen payment, webhook, and terminal modules with both Swagger dependencies excluded.

@gregjotau
gregjotau requested a review from a team as a code owner August 11, 2026 06:20

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pom.xml file to mark both the io.swagger:swagger-annotations and io.swagger.core.v3:swagger-annotations dependencies as optional. I have no feedback to provide as there are no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Swagger annotation dependencies optional

2 participants