Test one OverPassApi Query and convert to OSM.org/api/0.6/map#2
Open
alazar-tekle wants to merge 4 commits intoAddisMap:mainfrom
Open
Test one OverPassApi Query and convert to OSM.org/api/0.6/map#2alazar-tekle wants to merge 4 commits intoAddisMap:mainfrom
alazar-tekle wants to merge 4 commits intoAddisMap:mainfrom
Conversation
amenk
reviewed
Jun 11, 2022
|
|
||
| public function show($type, $id) | ||
| { | ||
| $query = '[out:json][timeout:400];way["tourism"="guest_house"](8.827402638625081,38.63822937011719,9.104808725563043,38.91632080078125);out%20body;'; |
Member
There was a problem hiding this comment.
you do not need to query overpass for this - you already have type and ID and can directly pass it to the show function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing fetching data from OverPassApi using Bounding boxes and then taking the osm_type and osm_id to get the JSON extension URL from OSM Main API
Eg. https://openstreetmap.org/api/0.6/{osm_type}/{osm_id}.json
But the method is not robust as querying such a huge data takes a very long response time and 99% fails so far (due to server timeout).