Ported Cluster and Archive client unit tests from Java by strangelydim · Pull Request #148 · AdaptiveConsulting/Aeron.NET

strangelydim · 2026-05-04T22:49:03Z

Added a new "Unsealer.Fody" Fody addin to allow tests to subclass sealed classes (Debug builds only).

Changed EgressPoller.OnFragment to skip over unknown schemaIds and continue to match Java behavior

Added ArchiveException.ErrorCodeAsString, made AeronArchive.QuietClose public, and added MessageRetryAttempts config option for parity with Java

Changed serialization of booleans in URIs to be lowercase "true/false" rather than .NET's default "True/False"

Changed AeronArchive.AsyncConnect to match Java's version and state machine

Fixed wrong decoder used in EgressAdapter.OnFragment's new leader event case

mikeb01 · 2026-05-11T02:50:15Z

+            var actualException = Assert.Throws<InvalidOperationException>(() => AeronArchive.ConnectAsync(ctx));
+            Assert.AreSame(error, actualException);
+
+            A.CallTo(() => ctx.Conclude()).MustHaveHappened().Then(


Formatting. We should break the link on the ., e.g:

A.CallTo(() => ctx.Conclude()).MustHaveHappened() .Then(A.CallTo(() => ctx.AeronClient()).MustHaveHappened()) .Then(A.CallTo(() => ctx.ControlResponseChannel()).MustHaveHappened()) .Then(A.CallTo(() => ctx.ControlResponseStreamId()).MustHaveHappened()) .Then(A.CallTo(() => aeron.AsyncAddSubscription( responseChannel, responseStreamId, A<AvailableImageHandler>._, A<UnavailableImageHandler>._)) .MustHaveHappened()) .Then(A.CallTo(() => ctx.Dispose()).MustHaveHappened());

There's are a few other instance similar to this.

mikeb01 · 2026-05-11T02:50:35Z

+            var actualException = Assert.Throws<IndexOutOfRangeException>(() => AeronArchive.ConnectAsync(ctx));
+            Assert.AreSame(error, actualException);
+
+            A.CallTo(() => ctx.Conclude()).MustHaveHappened().Then(


Formatting.

mikeb01 · 2026-05-11T03:04:07Z

            private long controlSessionId = Aeron.Aeron.NULL_VALUE;
            private byte[] encodedCredentialsFromChallenge = null;
-            private AsyncConnectState state = AsyncConnectState.ADD_PUBLICATION;
+            private AsyncConnectState state = AsyncConnectState.AWAIT_SUBSCRIPTION;


The Java code moves this code into the constructor, while functionally equivalent (on the happy path). I think it is clearer if this gets moved to a similar location to the Java version.

mikeb01 · 2026-05-11T03:06:49Z

@@ -3548,8 +3602,11 @@ public void Dispose()
                {
                    if (null != controlResponsePoller)


The Java implementation is doing a check for ownsAeronClient, is that required here?

Probably... added.

mikeb01 · 2026-05-11T03:10:34Z

                CheckDeadline();
                ctx.RunInvokers();

+                if (AsyncConnectState.AWAIT_SUBSCRIPTION == state)


The Java implementation uses a switch statement here instead a lot of ifs. It may be out of scope for this PR, but we should look at aligning the implementation.

Changed to switch.

mikeb01 · 2026-05-11T03:14:08Z

+                    object publication = null != archiveProxy ? (object)archiveProxy.Pub() : ctx.ControlRequestChannel();
+                    object subscription = null != controlResponsePoller
+                        ? (object)controlResponsePoller.Subscription()
+                        : ctx.ControlResponseChannel();


Formatting, should be:

throw new TimeoutException( "Archive connect timeout: step=" + state + " publication=" + publication + " subscription=" + subscription);

mikeb01 · 2026-05-11T03:45:24Z

+        {
+            public int DisposeCount { get; private set; }
+
+            public override void Dispose()


This requires that AeronCluster.Context.Dispose to be declared virtual. If there is an alternative to this implementation, then that would be better than a derived class. This looks like it is a replacement for a spy, which the .Net mocking library doesn't seem to support. If making the method virtual is the only solution, then I guess we need to go with that.

Turns out there was an alternative using Fody... so used that instead, Dispose is back to non-virtual.

mikeb01 · 2026-05-11T03:46:37Z

+
+            asyncConnect.Dispose();
+
+            A.CallTo(() => _aeron.Ctx).MustHaveHappened().Then(


Formatting.

mikeb01 · 2026-05-11T03:48:07Z

+
+            asyncConnect.Dispose();
+
+            A.CallTo(() => _aeron.Ctx).MustHaveHappened().Then(


Formatting.

mikeb01 · 2026-05-11T03:57:50Z

+
+        [SetUp]
+        public void SetUp()
+        {


A lot of this logic could move to field initialisation to better follow the Java implemementation.

Mostly fixed... some couldn't be moved due to .NET rules.

Added a new "Unsealer.Fody" Fody addin to allow tests to subclass sealed classes (Debug builds only). Changed EgressPoller.OnFragment to skip over unknown schemaIds and continue to match Java behavior Added ArchiveException.ErrorCodeAsString, made AeronArchive.QuietClose public, and added MessageRetryAttempts config option for parity with Java Changed serialization of booleans in URIs to be lowercase "true/false" rather than .NET's default "True/False" Changed AeronArchive.AsyncConnect to match Java's version and state machine Fixed wrong decoder used in EgressAdapter.OnFragment's new leader event case

mikeb01 · 2026-05-11T21:25:30Z

+        private EgressPoller _egressPoller;
+
+        [SetUp]
+        public void SetUp()


Initialisation can happen on the field and this setup method can be removed.

strangelydim requested a review from JPWatson May 4, 2026 22:49

strangelydim force-pushed the ebowden/port-cluster-and-archive-client-tests branch 2 times, most recently from fb5f03a to 24a1484 Compare May 8, 2026 19:07

mikeb01 reviewed May 11, 2026

View reviewed changes

strangelydim force-pushed the ebowden/port-cluster-and-archive-client-tests branch from 24a1484 to 90dbec7 Compare May 11, 2026 18:16

strangelydim force-pushed the ebowden/port-cluster-and-archive-client-tests branch from 90dbec7 to 1752af2 Compare May 11, 2026 18:30

strangelydim requested a review from mikeb01 May 11, 2026 18:33

mikeb01 reviewed May 11, 2026

View reviewed changes

mikeb01 merged commit fdb43ed into master May 11, 2026
4 checks passed

mikeb01 deleted the ebowden/port-cluster-and-archive-client-tests branch May 11, 2026 21:34

		@@ -3548,8 +3602,11 @@ public void Dispose()
		{
		if (null != controlResponsePoller)


		asyncConnect.Dispose();

		A.CallTo(() => _aeron.Ctx).MustHaveHappened().Then(

Conversation

strangelydim commented May 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikeb01 May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mikeb01 May 11, 2026 •

edited

Loading