Repository navigation
Fix meet_into keeping its own focus value when the meet is the source's - #179
Merged
luketpeterson merged 2 commits intoNov 5, 2026
Merged
Conversation
meet_into took any Identity from pmeet to mean its own value was the
result. Identity(COUNTER_IDENT) means the source's value is, so a
destination holding {1,2} met with a source holding {2} kept {1,2}.
Integer values never return COUNTER_IDENT, which is why only the
algebraic fuzzer's bitmask value type showed it.
Owner
|
Are we sure this is the only place this occurs? |
Collaborator
Author
|
bots say this is the only place, and seeing the fuzzing results and the tests, I think so as well |
Collaborator
|
Good fix. I was must have been thinking value meet would always be commutative when I wrote the buggy code. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meet_into took any Identity from pmeet to mean its own value was the result. Identity(COUNTER_IDENT) means the source's value is, so a destination holding {1,2} met with a source holding {2} kept {1,2}. Integer values never return COUNTER_IDENT, which is why only the algebraic fuzzer's bitmask value type showed it.