Add e3.anod.spec.Anod.deps_source_list#606
Draft
leocardao wants to merge 1 commit intoAdaCore:masterfrom
Draft
Conversation
grouigrokon
reviewed
Jul 21, 2023
grouigrokon
reviewed
Jul 21, 2023
leocardao
force-pushed
the
mr/cardao/split-deps-and-sources
branch
from
18f516b to
4084a6b
Compare
grouigrokon
reviewed
Aug 3, 2023
Contributor
grouigrokon
left a comment
grouigrokon
left a comment
There was a problem hiding this comment.
Feel like you want with the two typoes. If you want to let them be, it is not an enormous matter :)
leocardao
force-pushed
the
mr/cardao/split-deps-and-sources
branch
from
4084a6b to
8ac8fd5
Compare
e3.anod.spec.Anod.source_list contain the dependencies source list (any e3.anod.deps.Dependency that require 'source_pkg') e3.anod.spec.Anod.deps will not reference anymore the source_pkg dependencies.
leocardao
force-pushed
the
mr/cardao/split-deps-and-sources
branch
from
8ac8fd5 to
c0eba37
Compare
grouigrokon
approved these changes
Aug 3, 2023
Nikokrock
reviewed
Aug 4, 2023
Contributor
Nikokrock
left a comment
Nikokrock
left a comment
There was a problem hiding this comment.
I think a cannot approve as some specs use Source dep to access spec functions. I saw them while rewriting some .anod. We need to change those specs first
leocardao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e3.anod.spec.Anod.deps_source_list contain the dependencies source list (any e3.anod.deps.Dependency that require 'source_pkg')
e3.anod.spec.Anod.deps will not reference anymore the source_pkg dependencies.