Open
Conversation
Author
|
Fixed. |
CheezItMan
reviewed
Oct 17, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit all the time and space complexities and solved both problems using a dynamic programming approach. Well done. The only criticism I could find was the use of p, s and n for variable names.
| # Time Complexity: O(n) where n is the length of the array | ||
| # Space Complexity: O(1) | ||
|
|
||
| def max_sub_array(nums) |
| return string_solution[0...-1] | ||
| end | ||
|
|
||
| def p(n, s) |
There was a problem hiding this comment.
Just noting the variable names are not meaningful here.
| return s[n-1] if s[n-1] | ||
|
|
||
| if (n == 2) && !s[2-1] | ||
| s[2-1] = 1 |
| if (n == 2) && !s[2-1] | ||
| s[2-1] = 1 | ||
| else | ||
| s[n-1] = p(p(n - 1, s), s) + p(n - p(n - 1, s), s) |
There was a problem hiding this comment.
Nice both recursive and efficient solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For max_subarray, my method is passing all of the provided tests but there's another case I wrote a test for and it's failing. Will try to debug tomorrow (Sunday).