feat: add pinch-to-zoom support to editor by gahanad · Pull Request #2963 · Acode-Foundation/Acode

gahanad · 2026-10-09T08:27:45Z

Description

Adds pinch-to-zoom support to the editor to make editing more convenient on mobile devices.

Users can adjust the editor's font size using a two-finger pinch gesture, improving readability and usability on smaller screens.

Changes Made

Added a pinch-to-zoom extension for the editor.
Dynamically adjusts the editor font size based on the pinch gesture.
Enforces minimum and maximum font-size limits.
Saves the updated font size setting when the gesture ends.
Cleans up touch event listeners when the extension is destroyed.
Added unit tests covering pinch-zoom behavior and font-size calculations.

Testing

Added unit tests for pinch-zoom functionality.
Verified the targeted unit tests pass.
Manually tested pinch-to-zoom on an Android device.
Verified the full test suite and CI checks.

Related Issue

Closes #2426

greptile-apps · 2026-10-09T08:32:44Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge, with a non-blocking pinch recovery bug and the earlier saved-preset issue still open.

Findings

New pinch uses old distance ▶
Saved presets change shape ▶

Summary

Adds pinch-to-zoom to the main editor.

Two fingers on the editor now change and save its font size.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Two fingers touch editor] --> B[Record fingers and starting size]
  B --> C[Watch movement on document]
  C --> D{Movement held long enough?}
  D -->|Yes| E[Preview bounded font size]
  D -->|No| C
  E --> F[Finger lifts]
  F --> G[Apply latest distance]
  G --> H[Clear preview and save setting]

_{Reviews (8) · Last reviewed commit: "Merge upstream main into editor pinch zo..." · Reviewed by Greptile}

bajrangCoder · 2026-10-11T11:11:54Z

There several accidental zoom in/zoom out

screen-20261011-164227.mp4

gahanad · 2026-10-13T21:28:37Z

@greptile

bajrangCoder · 2026-10-15T15:47:13Z

+		persistFontSize();
+	}
+
+	const target = view.contentDOM;


Touch events keep targeting the element where each finger first landed, even after that element is removed from the DOM. Since move/end/cancel are only listened for on contentDOM, the gesture can get stuck:

Two fingers start on lines in the lower part of the editor; spread to ~2x.

The preview font change + requestMeasure() makes CM recompute a smaller viewport (visible area + ~500px margin), and the .cm-line under a finger is unmounted.

That finger's touchmove/touchend now dispatch to a detached node and never reach contentDOM.

Result: gesture.pinching stays true, the inline preview is never cleared or persisted, and every subsequent two-finger touchstart bails on if (gesture.pinching ...) — pinch is dead until the editor state is swapped.

Suggest attaching the move/end/cancel listeners to window/document (capture) when a pinch starts and removing them in endPinch/destroy.

bajrangCoder · 2026-10-15T16:04:15Z

Also isn't the line number area and editor area pinch-to-zoom at same time for better and smooth feel? as currently line number area adjusted itself after leaving zoom.

Also in some cases some accidental scrolls maybe using three finger/two finger etc does nothing but normally in acode those just scrolls so removing that will be a bit weird(if there is no valid reason)

…on#2961) Bumps ghcr.io/devcontainers/features/node from 2.1.0 to 2.1.1. --- updated-dependencies: - dependency-name: ghcr.io/devcontainers/features/node dependency-version: 2.1.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Updated Discord badge URL to a new endpoint.

…e-Foundation#2966) * refactor(browser): keep a list of devices in the emulator device list * refactor(browser): register each device when added to the list * feat(browser): apply the saved default preview size once layout is ready * feat(browser): save and restore a default device preview size * feat(browser): add "Set as Default" and "Clear Default" menu items * feat(browser): handle "Set as Default" and "Clear Default" actions * feat(browser): show default menu items only while Devices mode is on * feat(browser): open the preview in Devices mode when a default is set * feat(browser): restore the default preview mode on startup * refactor(browser): allow applying desktop mode without reloading * refactor(browser): make the reload in setDesktopMode optional * fix(browser): apply saved desktop mode before the first load to avoid a reload * fix(browser): only apply dimensions after layout, not desktop mode * fix(browser): re-fit saved presets to the current screen on restore * fix(browser): reload once after the saved size is applied * fix(browser): don't resize the webview before the emulator is set up * fix(browser): add reloadAfterLayout helper, only when a page was requested * fix(browser): show "Clear Default" only when a default is saved * fix(browser): refresh default menu items after Set as Default * fix(browser): refresh default menu items after Clear Default

gahanad · 2026-10-18T20:58:20Z

@greptile

greptile-apps · 2026-10-18T21:03:26Z

+        scaleSeekBar.getMax()
+      );
+      scaleSeekBar.setProgress(scale);
+      listener.onChange(getWidthProgress(), getHeightProgress(), scale / 100f);


Saved presets change shape

Restoring a saved preset uses the slider values instead of the dimensions calculated by selectDevice(). Each slider has a minimum of 300, but a fitted preset can be narrower. For example, an iPhone X fitted into a 600px-high preview is about 277px wide. Selecting it uses that width, but reopening the saved default uses 300px and changes its shape. Keep the fitted dimensions when applying the restored scale.

gahanad · 2026-10-18T21:32:34Z

Also isn't the line number area and editor area pinch-to-zoom at same time for better and smooth feel? as currently line number area adjusted itself after leaving zoom.

Also in some cases some accidental scrolls maybe using three finger/two finger etc does nothing but normally in acode those just scrolls so removing that will be a bit weird(if there is no valid reason)

I've added a guard so a three-finger touch no longer starts a pinch and keeps Acode's normal behaviour. For two fingers inside the editor the gesture is now claimed by pinch-to-zoom , that's the intended feature tradeoff , but if the browser starts native scrolling before the pinch is recognized, the code bails out and the scroll continues as before. Single-finger scrolling is untouched.

gahanad · 2026-10-19T21:49:51Z

@greptile

greptile-apps · 2026-10-19T21:54:21Z

+			const fingerStillDown =
+				getTrackedTouch(event.touches, gesture.firstId) ||
+				getTrackedTouch(event.touches, gesture.secondId);
+			if (fingerStillDown) return;


New pinch uses old distance

If a fresh pinch reuses finger identifiers after the previous gesture's end events were lost, fingerStillDown treats the new fingers as the old ones. It skips recovery and keeps the old starting distance.

For example, an abandoned 100px gesture followed by a new 200px → 240px pinch saves 29px instead of 14px from a 12px starting size. Use changedTouches to distinguish newly landed fingers from fingers that remain down before keeping the old gesture.

greptile-apps · 2026-10-19T21:54:26Z

Want your agent to iterate on Greptile's feedback? Try greploops.

bajrangCoder · 2026-10-20T05:01:41Z

+		// The rest of the gesture is observed on document: a finger's
+		// original target (.cm-line) can be unmounted by the preview
+		// re-measure, and events for a detached node never bubble back.
+		addGestureListeners();


Moving these listeners to document doesn't cover the unmounted-line case: an event dispatched to a detached node only propagates through that node's own (detached) ancestors, so document is never on its path — capture or bubble. The comment above assumes otherwise.

Quick check: after line.remove(), a capture touchmove listener on document receives nothing, while one on line itself still fires.

So when the preview re-measure unmounts the .cm-line under both fingers:

The zoomed preview stays inline and is never persisted.

The document listeners stay attached.

On the next touch in the editor, the recovery path in onTouchStart calls restorePreview(), so the size the user picked snaps back and is lost.

Suggest also attaching move/end/cancel to each tracked touch's target (first.target, second.target) at pinch start and removing them in endPinch/destroy — events for a detached element are still delivered to listeners on that element.

bajrangCoder · 2026-10-20T05:01:42Z

+			target.removeEventListener("touchmove", onTouchMove, true);
+			target.removeEventListener("touchend", endPinch, true);
+			target.removeEventListener("touchcancel", endPinch, true);


Nit: these three are never added to contentDOM anymore (they live on document and removeGestureListeners() above already cleans them up). Only the touchstart removal is needed here.

bajrangCoder · 2026-10-20T05:06:32Z

Also there should be a small setting in settings.json file(no need on ui side) to toggle this behavior.(Overall it looks fine now except few reviews which is already posted)

feat: add pinch-to-zoom support to editor

853265a

github-project-automation Bot added this to The Code Board - Acode Oct 9, 2026

github-actions Bot added the enhancement New feature or request label Oct 9, 2026

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread src/cm/pinchZoom.ts Outdated

Comment thread src/cm/pinchZoom.ts Outdated

Comment thread src/cm/pinchZoom.ts Outdated

Comment thread src/cm/pinchZoom.ts Outdated

fix: address pinch-to-zoom review feedback

1cf50ef

This comment was marked as outdated.

Sign in to view

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread src/cm/pinchZoom.ts Outdated

fix: address pinch-to-zoom review feedback

2e298a1

This comment was marked as outdated.

Sign in to view

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread src/cm/pinchZoom.ts Outdated

fix: address pinch-to-zoom review feedback

b771e77

This comment was marked as outdated.

Sign in to view

UnschooledGamer added the community label Oct 9, 2026

UnschooledGamer requested a review from bajrangCoder October 9, 2026 16:49

bajrangCoder reviewed Oct 11, 2026

View reviewed changes

Added pinch to zoom support to editor and made some changes

7dc0871

This comment was marked as outdated.

Sign in to view

greptile-apps Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread src/cm/pinchZoom.ts

Comment thread src/cm/touchSelectionMenu.js Outdated

Fixed corrections for pinchZoom

3be290d

gahanad requested a review from bajrangCoder October 13, 2026 21:32

bajrangCoder reviewed Oct 15, 2026

View reviewed changes

dependabot Bot and others added 5 commits October 16, 2026 02:45

chore: fix Discord badge URL in README (Acode-Foundation#2965)

90f745a

Updated Discord badge URL to a new endpoint.

Added pinchZoom correction

cf1635e

Fixed linting issue

300ef17

style: apply biome import order and formatting to pinch zoom sources

7a76d5b

greptile-apps Bot reviewed Oct 18, 2026

View reviewed changes

gahanad added 3 commits October 20, 2026 02:57

test: improve pinch zoom gesture coverage

7b4b49a

Merge origin/main into feat/editor-pinch-to-zoom

2916224

Merge upstream main into editor pinch zoom

31df5c5

greptile-apps Bot reviewed Oct 19, 2026

View reviewed changes

bajrangCoder reviewed Oct 20, 2026

View reviewed changes

bajrangCoder self-assigned this Oct 20, 2026

Conversation

gahanad commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Testing

Related Issue

Uh oh!

greptile-apps Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Findings

Summary

Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

bajrangCoder commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

gahanad commented Oct 13, 2026

Uh oh!

bajrangCoder Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

bajrangCoder commented Oct 15, 2026

Uh oh!

gahanad commented Oct 18, 2026

Uh oh!

Uh oh!

greptile-apps Bot Oct 18, 2026

Choose a reason for hiding this comment

Uh oh!

gahanad commented Oct 18, 2026

Uh oh!

gahanad commented Oct 19, 2026

Uh oh!

greptile-apps Bot Oct 19, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 19, 2026

Uh oh!

bajrangCoder Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

bajrangCoder Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

bajrangCoder commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gahanad commented Oct 9, 2026 •

edited

Loading

greptile-apps Bot commented Oct 9, 2026 •

edited

Loading

bajrangCoder commented Oct 11, 2026 •

edited

Loading