Skip to content

chore(deps): remove webpack and it's deps#2017

Merged
UnschooledGamer merged 1 commit intoAcode-Foundation:mainfrom
UnschooledGamer:rm/webpack-deps
Apr 8, 2026
Merged

chore(deps): remove webpack and it's deps#2017
UnschooledGamer merged 1 commit intoAcode-Foundation:mainfrom
UnschooledGamer:rm/webpack-deps

Conversation

@UnschooledGamer
Copy link
Copy Markdown
Member

@UnschooledGamer UnschooledGamer commented Apr 8, 2026

-# this is community PR, it should go under community tag/status in projects and labels too

@UnschooledGamer UnschooledGamer self-assigned this Apr 8, 2026
@UnschooledGamer UnschooledGamer merged commit 0459064 into Acode-Foundation:main Apr 8, 2026
8 checks passed
@UnschooledGamer UnschooledGamer deleted the rm/webpack-deps branch April 8, 2026 07:30
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This PR removes webpack (^5.105.0) and webpack-cli (^6.0.1) from devDependencies, which is consistent with the project's build system — both build.sh and start.sh already invoke rspack via @rspack/cli/@rspack/core, not webpack. The package-lock.json changes reflect these packages being demoted to peer dependencies of other remaining packages rather than direct dependencies.

Confidence Score: 5/5

Safe to merge — the removal of webpack/webpack-cli is correct since the build system already uses rspack exclusively.

Both build and start scripts invoke rspack (not webpack), and rspack.config.js uses @rspack/core directly. No webpack API is imported in source code — the webpackChunkName magic comments in source files are fully supported by rspack's compatibility layer. No P0 or P1 issues identified.

No files require special attention.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename Overview
package.json Removes webpack and webpack-cli from devDependencies; build scripts already use rspack exclusively so this is a correct cleanup.
package-lock.json Lock file updated to reflect webpack/webpack-cli removal and reclassifies remaining webpack sub-packages as peer dependencies of other tools.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[npm run build / start] --> B[utils/scripts/build.sh or start.sh]
    B --> C[node ./utils/config.js]
    B --> D["rspack --mode [development|production]"]
    D --> E["@rspack/cli + @rspack/core"]
    E --> F[rspack.config.js]
    F --> G[Bundled output → www/build/]
    X["webpack + webpack-cli (REMOVED)"] -. no longer needed .-> D
    style X fill:#ffcccc,stroke:#cc0000,stroke-dasharray: 5 5
    style E fill:#ccffcc,stroke:#009900
Loading

Reviews (1): Last reviewed commit: "chore(deps): remove webpack and it's dep..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant