fix(int): OpenColorIO exception safety improvements - #5428
Open
lgritz wants to merge 1 commit into
Open
Conversation
We had recently done a around to be sure that all OCIO calls were wrapped in try/catch (since OCIO uses exceptions, and we do not). But mostly we were catching `OCIO::Exception` and that was ok for an exception purposely thrown by OCIO, but what about an exception thrown by a system library call that OCIO failed to catch? It wouldn't be an OCIO::Exception, it would be a std::exception. So catch those instead. OCIO::Exception derive from std::runtime_error, which derives from std::exception, so nothing will be missed because of this... but more things might get caught. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had recently done a around to be sure that all OCIO calls were wrapped in try/catch (since OCIO uses exceptions, and we do not). But mostly we were catching
OCIO::Exceptionand that was ok for an exception purposely thrown by OCIO, but what about an exception thrown by a system library call that OCIO called and failed to catch? It wouldn't be an OCIO::Exception, it would be a std::exception.So catch those instead. OCIO::Exception derive from std::runtime_error, which derives from std::exception, so nothing will be missed because of this... but more things might get caught.