Fix linking to self-built deps on Windows + Clang#2273
Open
dimula73 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
Fix linking to self-built deps on Windows + Clang#2273dimula73 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
dimula73 wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
1) Expat: 'MD' suffix is added on MSVC only, 'd' suffix is added on WIN32 2) ZLib: 'd' suffix is added only on MSVC
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCIO fails to build on Windows when llvm-mingw environment is used. It happens because of incorrect conditions are used to mimic the static library names. This patch makes these names generation consistent with the CMakeLists.txt files of the corresponding deps.