Conversation
The two call sites in Arimaa omitted the interpolation parameter, so the
message rendered literally as "The cell {{where}} is already occupied."
141 of the 148 call sites across the games already pass it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QDibMmzgf18ky9fiCRW5cL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tldr: Making an error message not have an untranslated
{{where}}.Otherwise the Arimaa fix looks good. The move list looking to not list the rabbits is purely visual; I tested with a game against an alt account and it corrects itself to the full move that the backend has as soon as you submit the move.
Arimaa: pass the cell into the OCCUPIED validation message
Both Arimaa call sites for
apgames:validation._general.OCCUPIEDomitted the interpolation parameter, so the message rendered with the placeholder intact:141 of the 148 call sites across the games already pass
where, and the string has always had the placeholder, so this is just an oversight. Now reads "The cell e2 is already occupied."Two call sites:
validateMove, placement branch). Reachable by typing a cell that's already taken, or naming one cell twice in a single setup move. Arimaa Input QoL #477 routed the duplicate-cell case here, which is how I noticed.validateMove, movement branch,to is empty). Same omission; not touched by Arimaa Input QoL #477, fixed here for consistency.Three existing assertions in
Can't place two pieces on one cellupdated to passwhere.