Implementing new JMF Jacoco solution#165
Conversation
tmikula-dev
requested review from
Zejnilovic,
benedeki,
dk1844,
jakipatryk,
lsulak,
miroslavpojer and
salamonpavel
as code owners
|
Warning Review limit reached
More reviews will be available in 8 minutes and 35 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2") | ||
|
|
||
| addSbtPlugin("io.github.davidmweber" % "flyway-sbt" % "7.4.0") | ||
| addSbtPlugin("io.github.moranaapps" % "jacoco-method-filter-sbt" % "2.1.1") |
There was a problem hiding this comment.
2.2.0 has been released.
| - name: faDbCore | ||
| paths: | ||
| - '**/core/target/**/jacoco-report/jacoco.xml' | ||
| thresholds: '61*80*0' |
There was a problem hiding this comment.
Why 0? I would suggest 60%
It give space and now there is the eay how to filter out no coverable methods.
| } | ||
|
|
||
| core.setFailed('JaCoCo test coverage report generation failed, and related PR comments were updated.'); | ||
| global-thresholds: '0*80' |
There was a problem hiding this comment.
Here I would use current global value as start point.
|
|
||
| core.setFailed('JaCoCo test coverage report generation failed, and related PR comments were updated.'); | ||
| global-thresholds: '0*80' | ||
| report-thresholds-default: '0*0*0' |
There was a problem hiding this comment.
Here I would use the lowest report group value for 1st position then 80*60.
| # ───────────────────────────────────────────────────────────────────────────── | ||
| # Prefix a rule with "+" to rescue a method. Include always wins over exclude. | ||
| # | ||
| # +com.example.model.Config$#apply(*) id:keep-config-apply |
There was a problem hiding this comment.
These example lines should be replaced by real include rules if needed or removed.
During the adoption there should be done a check if there is some method filtered by boiler plate code - the team override it.
2 participants
Overview
This pull request updates the project's test coverage workflow and build plugins to improve efficiency and maintainability. The main changes are the addition of a smart detection step to only run JaCoCo coverage checks when Scala source files are changed, the upgrade of the JaCoCo report action, and the removal of custom SBT JaCoCo plugins in favor of an upstream plugin.
Release Notes
Related
Closes #157