Skip to content

Fix(reader): toggle controls from the whole reader surface, not per-item #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aatricks merged 1 commit into from
Jul 6, 2026
Merged

Fix(reader): toggle controls from the whole reader surface, not per-item #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions app/src/main/java/io/aatricks/easyreader/ui/screens/reader/ReaderContentArea.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import androidx.compose.animation.AnimatedVisibility
import androidx.compose.animation.slideInVertically
import androidx.compose.animation.slideOutVertically
import androidx.compose.foundation.background
import androidx.compose.foundation.gestures.detectTapGestures
import androidx.compose.foundation.interaction.DragInteraction
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
Expand Down Expand Up @@ -33,6 +34,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.Alignment
import androidx.compose.ui.graphics.vector.ImageVector
import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.input.pointer.pointerInput
import androidx.compose.ui.unit.dp
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.LifecycleEventObserver
Expand Down Expand Up @@ -293,6 +295,16 @@ internal fun ContentArea(
Box(
modifier = Modifier
.fillMaxSize()
// Single full-screen tap authority for toggling the reader controls. The
// per-item clickables only cover text glyphs, so horizontal margins,
// inter-paragraph gaps, and empty space below a short chapter were dead
// zones where a tap did nothing — felt like the tap "didn't register",
// worst when dismissing the menu (its bars shrink the reliable target).
// detectTapGestures cancels on any consumed movement, so the LazyColumn /
// pager still win drags; only clean taps that no child consumed reach here.
.pointerInput(Unit) {
detectTapGestures { readerViewModel.toggleControls() }
}
.drawWithContent {
if (uiState.showControls && edgeBlurCaptureGeneration != edgeBlurLastCaptured) {
edgeBlurLayer.record(
Expand Down
Loading