Implemented a way to invert the drift velocity direction inside the ATTPC. Also fixed the padplane-projected hits issue by adding a charge threshold...#258
Open
RealAurio wants to merge 1 commit intoATTPC:developfrom
Conversation
…TTPC. Also fixed the padplane-projected hits issue by adding a charge threshold...
RealAurio
force-pushed
the
driftDirectionInversion
branch
from
f6f41aa to
8397cb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change. Added a geometry parameter on AtDigiPar which determines if the drift direction is inverted or not:
If this parameter is not set in the .par file, the default value is set to 0, so that all previous .par files should still work as expected.
I also added a quick fix for a test simulation from #257 which removes the padplane-projected hits. I thought those had something to do with the inversion of the drift velocity, but they ended up just being produced by the AtPSA when no peak can be found for the pad. Adding a charge threshold of 5 removes those.