Repository navigation
A symbol a numerator sum's coefficients share comes out in front of the partial fractions - #1836
Merged
Merged
Conversation
…he partial fractions Part of #718. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #718.
(b d + 2c d x)^9/(a + b x + c x^2)^3ran past a minute, where(b + 2c x)^9/(a + b x + c x^2)^3is answered in two seconds. The shareddstood in every coefficient the partial fractions divide.SolveByPartialFractionsnow first takes a symbol that a numerator sum's coefficients share out in front of the integral. Left in the numerator as a constant factor, it was still slow for the same reason.314fa885(b d + 2c d x)^9/(a + b x + c x^2)^3(b d + 2c d x)^8/(a + b x + c x^2)^3The answers are as long as master's for the forms without
d: 76,153 and 65,140 characters. That length is how the partial fractions answer an odd power of the denominator's derivative over a power of it, whichu = a + b x + c x^2would answer in a few lines. It is not this change, and is the next one.Tests:
ContentOutOfANumeratorSumIntegralTest, the second row, differentiated back and compared at six points.Measured on 14,109 corpus problems, every one whose integrand is a rational function and every one with a secant or a cosecant in it, at the corpus's 5-second budget, against master
314fa885:Three problems are answered here and not on master, the two of 1.2.1.2 above and one of 1.2.2.4, and none the other way. On the 13,926 both answer the time is 2,100 seconds on master and 2,094 here.
The harness counts no answer wrong in either. The three problems the builds disagreed on, run again one build at a time: master answers none within the budget, this all three.
The suite passes: 15,191 passed, 13 skipped, none failed. The allocation gate passes: every gated benchmark allocates what the baseline says. The library builds for every target. The entry in
BREAKING-CHANGES.mdis measured on a build of 2.5.0.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura