Fix Import Error: ajv-draft-04#268
Merged
philsturgeon merged 1 commit intoAPIDevTools:mainfrom Feb 11, 2025
Merged
Conversation
bh2smith
added a commit
to BitteProtocol/make-agent
that referenced
this pull request
Feb 6, 2025
There seems to be some unusual import error that end users get without this package. I have proposed a potential solution in the dependency repo: APIDevTools/swagger-parser#268 In the meantime, we just put this back here.
philsturgeon
approved these changes
Feb 11, 2025
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of this package keep running into the following import issue: This forces users to include
ajv-draft-04into their project dependencies even if they are not directly using it. This PR proposes moving the import statement into the only code block where it is actually required and thus (hopefully) avoiding the error. Its a bit surprising that the dependencies don't force the package to be there. Maybe there is some other problem at play...