feat: Add Aossie github link on navbar (#16)#17
feat: Add Aossie github link on navbar (#16)#17akshat3410 wants to merge 2 commits intoAOSSIE-Org:mainfrom
Conversation
github-actions
bot
added
no-issue-linked
WalkthroughAdded GitHub repository links to the navbar component in both desktop and mobile navigation views, including a Github icon import and accessibility attributes for the new desktop link. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/Pages/Landing` page/Navbar.tsx:
- Around line 149-160: Extract the duplicated GitHub URL string into a single
constant (e.g., GITHUB_REPO_URL) and replace the hard-coded URL in both anchor
tags in the Navbar component so both desktop and mobile links reference that
constant; add the constant near the top of Navbar.tsx (or in a shared constants
file) and update the href attributes in the anchors that render the Github icon
to use GITHUB_REPO_URL.
- Around line 210-221: The "GitHub" label in the Navbar anchor is hardcoded;
update the Navbar component to use the i18n resource lookup instead (e.g.,
t('github') or a shared strings object) in place of the literal "GitHub", add
the corresponding key ("github": "GitHub") to the translation/resource files for
supported locales, and ensure the anchor still calls setIsOpen(false) and
renders the Github icon component exactly as before; also provide a sensible
fallback if the i18n key is missing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4627df73-964a-48d7-babb-8e32c9317166
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
src/Pages/Landing page/Navbar.tsx
| {/* GitHub Repository Link */} | ||
| <a | ||
| href="https://github.com/AOSSIE-Org/PictoPy" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="text-gray-800 dark:text-gray-300 | ||
| hover:text-black dark:hover:text-white | ||
| transition-colors duration-300" | ||
| aria-label="AOSSIE PictoPy GitHub Repository" | ||
| > | ||
| <Github className="h-5 w-5" /> | ||
| </a> |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider extracting the GitHub URL to a constant.
The GitHub repository URL https://github.com/AOSSIE-Org/PictoPy is duplicated in both the desktop (line 151) and mobile (line 211) navigation sections. Extracting it to a constant improves maintainability.
♻️ Proposed refactor
Add a constant at the top of the component or in a shared constants file:
const GITHUB_REPO_URL = "https://github.com/AOSSIE-Org/PictoPy";Then reference it in both links:
<a
- href="https://github.com/AOSSIE-Org/PictoPy"
+ href={GITHUB_REPO_URL}
target="_blank"Also applies to: 210-221
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/Pages/Landing` page/Navbar.tsx around lines 149 - 160, Extract the
duplicated GitHub URL string into a single constant (e.g., GITHUB_REPO_URL) and
replace the hard-coded URL in both anchor tags in the Navbar component so both
desktop and mobile links reference that constant; add the constant near the top
of Navbar.tsx (or in a shared constants file) and update the href attributes in
the anchors that render the Github icon to use GITHUB_REPO_URL.
| <a | ||
| href="https://github.com/AOSSIE-Org/PictoPy" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="text-gray-700 dark:text-gray-300 text-lg font-medium | ||
| hover:text-black dark:hover:text-white | ||
| transition duration-300 flex items-center space-x-2" | ||
| onClick={() => setIsOpen(false)} | ||
| > | ||
| <Github className="h-5 w-5" /> | ||
| <span>GitHub</span> | ||
| </a> |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Externalize the user-visible string for i18n.
The "GitHub" text on line 220 is hardcoded. Per coding guidelines, user-visible strings should be externalized to resource files for internationalization.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/Pages/Landing` page/Navbar.tsx around lines 210 - 221, The "GitHub" label
in the Navbar anchor is hardcoded; update the Navbar component to use the i18n
resource lookup instead (e.g., t('github') or a shared strings object) in place
of the literal "GitHub", add the corresponding key ("github": "GitHub") to the
translation/resource files for supported locales, and ensure the anchor still
calls setIsOpen(false) and renders the Github icon component exactly as before;
also provide a sensible fallback if the i18n key is missing.
1 participant
This PR adds a GitHub social link to the PictoPy navigation bar, linking directly to the AOSSIE-Org/PictoPy repository.
Why add this?
Our code is open-source, and as a project under AOSSIE, it's really important that we make it as easy as possible for users and potential contributors to find our source code.
By having a visible GitHub icon directly in the navbar:
Changes Made:
lucide-react.Screenshot:
Summary by CodeRabbit