Skip to content

Fix GitHub API crashes on non-array responses (#225) #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhruvv16-hash wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix GitHub API crashes on non-array responses (#225) #227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0853c45
Fix GitHub API crashes on non-array responses (#225)
dhruvv16-hash Sep 9, 2026
f5fb3b3
Handle 204 and 202 status codes in fetchWithCache to prevent JSON par…
dhruvv16-hash Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/services/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ async function fetchWithCache(url, pat) {

if (res.status === 403) throw new Error('RATE_LIMIT')
if (res.status === 404) throw new Error('NOT_FOUND')
if (res.status === 204 || res.status === 202) return []
if (!res.ok) throw new Error(`HTTP_${res.status}`)

const data = await res.json()
Expand All @@ -92,6 +93,7 @@ export async function fetchRepos(org, repoCount, pat) {
for (let page = 1; page <= maxPages; page++) {
const url = `https://api.github.com/orgs/${org}/repos?per_page=100&page=${page}&sort=updated`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
Comment on lines 94 to 97
if (data.length < 100) break
}
Expand All @@ -104,6 +106,7 @@ export async function fetchContributors(org, repo, pat) {
for(let page = 1; page<=maxPages ; page++) {
const url = `https://api.github.com/repos/${org}/${repo}/contributors?per_page=100&page=${page}`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
if(data.length < 100) break
}
Expand All @@ -116,6 +119,7 @@ export async function fetchIssues(org, repo, pat) {
for(let page = 1; page<=maxPages ; page++) {
const url = `https://api.github.com/repos/${org}/${repo}/issues?state=all&per_page=100&page=${page}`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
if(data.length < 100) break
}
Expand All @@ -128,6 +132,7 @@ export async function fetchPulls(org, repo, pat) {
for(let page = 1; page<=maxPages ; page++) {
const url = `https://api.github.com/repos/${org}/${repo}/pulls?state=all&per_page=100&page=${page}`
const data = await fetchWithCache(url, pat)
if (!Array.isArray(data)) break
all.push(...data)
if(data.length < 100) break
}
Expand Down
Loading