Skip to content

fix(hub): hide left-panel login button in multi-auth modes#153

Open
mariodruiz wants to merge 1 commit into
AMDResearch:developfrom
mariodruiz:fix/multi-auth-failed-login-layout
Open

fix(hub): hide left-panel login button in multi-auth modes#153
mariodruiz wants to merge 1 commit into
AMDResearch:developfrom
mariodruiz:fix/multi-auth-failed-login-layout

Conversation

@mariodruiz

Copy link
Copy Markdown
Contributor

Summary

  • On failed native login in multi auth mode, JupyterHub re-renders with the sub-authenticator's login_service, causing a "Sign in with Native" button to appear on the left panel
    • This is confusing since the right panel already has the full multi-auth form
    • Fix: skip the left-panel button when authenticator_mode starts with multi

Checklist

  • Code follows project style guidelines
  • Changes are backward compatible
  • Tested on local Kubernetes cluster
  • Documentation links updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed native login shows “Sign in with Native” on left panel instead of preserving multi-auth login layout

1 participant