fix(hub): decouple GitHub username prefix from login_service label#147
Open
mariodruiz wants to merge 2 commits into
Open
fix(hub): decouple GitHub username prefix from login_service label#147mariodruiz wants to merge 2 commits into
mariodruiz wants to merge 2 commits into
Conversation
Contributor
Author
|
Please, squash before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The multiauthenticator library derives a user's identity prefix from the
login_service display label, so the "github:" prefix that team sync, group
assignment, and resource resolution depend on only worked because the
default label happened to normalize to "github". Setting login_service to
something like "GitHub Enterprise" would silently break every
startswith("github:") check.
Pin an explicit prefix on CustomGitHubOAuthenticator so identity no longer
tracks the display label, and centralize the literal as GITHUB_USERNAME_PREFIX
to replace the 10 scattered "github:" strings across setup, handlers, and
groups.
Changes
Define global
GITHUB_USERNAME_PREFIXChecklist