Skip to content

Remove --parallel_threads flag from to_huggingface.py #4977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 24, 2026
Merged

Remove --parallel_threads flag from to_huggingface.py #4977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions src/maxtext/checkpoint_conversion/to_huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,6 @@
"the instruction-tuned one).",
)

flags.DEFINE_integer(
"parallel_threads",
4,
"Number of threads used for parallel saving of weights. Lower this value to reduce peak host RAM usage.",
)
flags.register_validator(
"parallel_threads",
lambda value: value > 0,
message="--parallel_threads must be a positive integer.",
)

FLAGS = flags.FLAGS
Comment thread
chiajunglien marked this conversation as resolved.


Expand Down Expand Up @@ -453,14 +442,7 @@ def _transform_and_save_weights(
raise ValueError("Error: No weights were transformed. Check mappings and parameter paths.")

max_logging.log("\nSaving HuggingFace model...")
save_model_files(
transformed_hf_weights,
hf_config_obj,
tokenizer,
processor,
output_directory,
parallel_threads=FLAGS.parallel_threads,
)
save_model_files(transformed_hf_weights, hf_config_obj, tokenizer, processor, output_directory)
max_logging.log(f"✅ MaxText model successfully saved in HuggingFace format at {output_directory}")

max_logging.log(f"Elapse for transform and save: {(time.time() - start) / 60:.2f} min")
Expand Down
Loading