-
Notifications
You must be signed in to change notification settings - Fork 591
Jfacevedo kimi k3 #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
entrpn
wants to merge
23
commits into
main
Choose a base branch
from
jfacevedo_kimi_k3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jfacevedo kimi k3 #4967
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
bcf0dfc
feat(kimi_k3): Step 1 - Add Kimi K3 decoder block type, configs, and …
jfacevedo-google 9a4d02f
feat(kimi_k3): Step 2 - Add SituAndMul activation function and unit t…
jfacevedo-google 232f28c
feat(kimi_k3): Step 3 - Add Kimi Decoupled Attention (KDA) layer and …
jfacevedo-google a26b104
feat(kimi_k3): Step 4 - Add mla_use_output_gate to MLA layer and unit…
jfacevedo-google 769a4af
feat(kimi_k3): Step 5 - Add 896-expert MoE & Latent MoE support and u…
jfacevedo-google 79db3d2
feat(kimi_k3): Step 6 - Assemble KimiLinearModel backbone and add end…
jfacevedo-google bf801f4
feat(kimi_k3): Add routed_bias: true for noaux_tc quantile balancing …
jfacevedo-google 7cb4f8a
feat(kimi_k3): Add HuggingFace weight conversion, MXFP4 dequantizatio…
jfacevedo-google 55fc3ff
test(kimi_k3): Add 2-layer logit parity test with Orbax restore and f…
jfacevedo-google b109254
test(kimi_k3): Wire multi-process runner into KimiK3LogitParityTest f…
jfacevedo-google 2b10f89
fix(kimi_k3): Fix KimiDecoderLayer deterministic evaluation & add rig…
jfacevedo-google 25f141a
fix(kimi_k3): Address PR 4967 reviews - add ShortConv1D autoregressiv…
jfacevedo-google c5aa91d
fix(conversion): Safely resolve model_name from config in to_maxtext …
jfacevedo-google ce4ee5d
fix(conversion): Add import logging in to_maxtext and map KDA vs MLA …
jfacevedo-google 25e4dca
fix(conversion): Add o_norm-scale to KDA param mapping
jfacevedo-google 1a26699
fix(conversion): Use max_logging.log for index fallback warning
jfacevedo-google 00100c7
test(kimi_k3): Fix layer indexing assertion in kimi_k3_hf_loading_test
jfacevedo-google efdb877
fix(conversion): Convert output_directory to absolute path for Orbax …
jfacevedo-google e858978
perf(test): Use jax.eval_shape to eliminate memory allocation and ena…
jfacevedo-google d433ac1
test(kimi_k3): Update kimi_k3_hf_loading_test with StandardRestore an…
jfacevedo-google e4b1133
test(kimi_k3): Mark KimiK3HFLoadingTest with pytest.mark.tpu_only to …
jfacevedo-google 8b89d5b
fix(test): Use pure Linen model and get_abstract_param to completely …
jfacevedo-google a629e96
test(kimi_k3): Use 100% pure Flax NNX with nnx.eval_shape, nnx.split,…
jfacevedo-google File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silently returning zeros when a key is not found in the HF checkpoint index can mask parameter mapping typos or missing weights, leading to silent model corruption. It is highly recommended to log a warning when this fallback occurs.