Supports batching in vLLM offline inference script#3932
Open
learning-to-play wants to merge 1 commit into
Open
Supports batching in vLLM offline inference script#3932learning-to-play wants to merge 1 commit into
learning-to-play wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NicoGrande
approved these changes
May 18, 2026
jrplatin
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support batching in vLLM offline inference script
This change enables batching in the
vllm_decode.pyoffline inference script by duplicating the input prompt based on theper_device_batch_sizeconfiguration parameter.Details:
per_device_batch_size.per_device_batch_sizetointto preventTypeErrorwhen the parameter defaults to a float (e.g.,12.0inbase.yml).per_device_batch_sizeon the command line.Tests
I verified this change by running the
vllm_decodescript on a TPU v5e-8 VM withper_device_batch_sizeset to different values, confirming that it batches correctly and generates outputs.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.