Skip to content

Update tokamax group sizes for pipeline#3397

Open
NuojCheng wants to merge 1 commit intomainfrom
chengnuojin-enable-pipeline-2dfsdp
Open

Update tokamax group sizes for pipeline#3397
NuojCheng wants to merge 1 commit intomainfrom
chengnuojin-enable-pipeline-2dfsdp

Conversation

@NuojCheng
Copy link
Collaborator

@NuojCheng NuojCheng commented Mar 12, 2026

Description

We got tokamax shape error when using pipeline_fsdp_ag_per_repeat=true and model_name=deepseek3-671b-2dfsdp. This PR fixes the error.

Tests

Given branch passes this train compile script.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants