Update path for CODEOWNERS#3396
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a10b670 to
72c6084
Compare
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR successfully updates the paths in the CODEOWNERS file to reflect the recent codebase restructure, moving away from src/MaxText to lowercase src/maxtext. The removal of elastic_train.py paths is also correctly handled.
🔍 General Feedback
- Path Clarity: Several entries targeting directories were updated without trailing slashes. It's best practice in
CODEOWNERSto append/to directory paths. - Root Files: Changing
*.mdtodocsmeans root-level markdown files (e.g.,README.md) are no longer tracked in CODEOWNERS. Consider if this was the intent. - Cleanup: Some existing duplicate usernames (e.g.
@suexu1025) were preserved during the path rename, which have been noted for cleanup.
72c6084 to
387f74c
Compare
igorts-git
approved these changes
Mar 12, 2026
bvandermoon
approved these changes
Mar 12, 2026
Collaborator
bvandermoon
left a comment
There was a problem hiding this comment.
LGTM, thanks @RissyRan. There is a copybara change that goes along with this as well. I'll send it to in case you haven't seen it already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the path due to recent restructure.
src/maxtext/elastic_train.pyis expected to removeTests
Manual check
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.