Skip to content

Update path for CODEOWNERS#3396

Merged
copybara-service[bot] merged 1 commit intomainfrom
update_code_path
Mar 12, 2026
Merged

Update path for CODEOWNERS#3396
copybara-service[bot] merged 1 commit intomainfrom
update_code_path

Conversation

@RissyRan
Copy link
Collaborator

@RissyRan RissyRan commented Mar 12, 2026

Description

Update the path due to recent restructure.

  • Confirmed with Luke src/maxtext/elastic_train.py is expected to remove
  • Remove duplicated owners and format clean up

Tests

Manual check

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This PR successfully updates the paths in the CODEOWNERS file to reflect the recent codebase restructure, moving away from src/MaxText to lowercase src/maxtext. The removal of elastic_train.py paths is also correctly handled.

🔍 General Feedback

  • Path Clarity: Several entries targeting directories were updated without trailing slashes. It's best practice in CODEOWNERS to append / to directory paths.
  • Root Files: Changing *.md to docs means root-level markdown files (e.g., README.md) are no longer tracked in CODEOWNERS. Consider if this was the intent.
  • Cleanup: Some existing duplicate usernames (e.g. @suexu1025) were preserved during the path rename, which have been noted for cleanup.

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @RissyRan. There is a copybara change that goes along with this as well. I'll send it to in case you haven't seen it already

@copybara-service copybara-service bot merged commit ef98ae5 into main Mar 12, 2026
40 checks passed
@copybara-service copybara-service bot deleted the update_code_path branch March 12, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants