Skip to content

Add support to infer config with no config file#3373

Open
dipannita08 wants to merge 1 commit intomainfrom
maxtext-rl-uxr-config-flags
Open

Add support to infer config with no config file#3373
dipannita08 wants to merge 1 commit intomainfrom
maxtext-rl-uxr-config-flags

Conversation

@dipannita08
Copy link
Collaborator

@dipannita08 dipannita08 commented Mar 11, 2026

Description

Currently users need to pass in the file path to config file when running MaxText workloads (src/maxtext/configs/post_train/rl.yml)

This change adds support to resolve or infer the config without requiring the user to specify the config path, while previous functionality is still supported.

FIXES: b/491604657

Tests

  • CI
  • Run a workload without config:
python3 -m maxtext.trainers.pre_train.train \
  run_name=$RUN_NAME \
  base_output_directory=$OUTPUT_PATH \
  dataset_type=synthetic \
  steps=$STEPS
  • Run a workload with config:
python3 -m maxtext.trainers.pre_train.train src/maxtext/configs/base.yml \
  run_name=$RUN_NAME \
  base_output_directory=$OUTPUT_PATH \
  dataset_type=synthetic \
  steps=$STEPS

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dipannita08. Is it significantly harder to infer the config needed based on the command (like you had mentioned previously) and just pass that directly through?

@dipannita08 dipannita08 changed the title Add support for config flag with no file path Add support to infer config with no config file Mar 11, 2026
@dipannita08 dipannita08 force-pushed the maxtext-rl-uxr-config-flags branch from 7d768d9 to 6c8811f Compare March 11, 2026 23:07
@dipannita08 dipannita08 force-pushed the maxtext-rl-uxr-config-flags branch 2 times, most recently from 738eab3 to 31c9067 Compare March 12, 2026 02:09
@dipannita08 dipannita08 force-pushed the maxtext-rl-uxr-config-flags branch from d6949f2 to e4e72b3 Compare March 12, 2026 22:04
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @dipannita08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants