Make tokenizer_path to be non-mandatory#3367
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
Collaborator
|
Can we do the similar change for SFT? |
f3cf026 to
e176cf9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
a9659e3 to
ffa2895
Compare
Collaborator
Author
Yes done now |
4c0f0ec to
ba2ad97
Compare
ba2ad97 to
2759471
Compare
SurbhiJainUSC
approved these changes
Mar 12, 2026
2759471 to
0b590c8
Compare
bvandermoon
approved these changes
Mar 12, 2026
969db06 to
8b8e8d7
Compare
8b8e8d7 to
c9f493e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify the parameters for running on MaxText by removing
tokenizer_pathas a required argument.FIXES: b/490520651
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Ran locally on a v5p-8 the following commands:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.