Add Google Cloud ML Diagnostics metrics documentation - #466
Open
richaguptaa17 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a comprehensive guide on metrics collection and monitoring with Google Cloud ML Diagnostics (docs/metrics.md) and updates the README.md to link to it. The review feedback identifies two key improvements in the new documentation: correcting the gcloud logging query filters to use jsonPayload.metric_name instead of resource.labels.namespace, and replacing LaTeX arrow syntax with standard Unicode arrows to ensure proper markdown rendering.
## Summary Adds documentation (`docs/metrics.md`) and `README.md` references for Google Cloud ML Diagnostics metrics integration in MaxDiffusion training runs. ## Key Additions - `docs/metrics.md`: Guide for capturing metrics using `google-cloud-mldiagnostics`. - `README.md`: Added `Metrics` section and Table of Contents link pointing to `docs/metrics.md`.
richaguptaa17
force-pushed
the
docs-mldiagnostics-metrics
branch
from
August 25, 2026 07:30
3e0b9bc to
8cf0935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds documentation (
docs/metrics.md) andREADME.mdreferences for Google Cloud ML Diagnostics metrics integration in MaxDiffusion training runs.Key Additions
docs/metrics.md: Guide for capturing metrics usinggoogle-cloud-mldiagnostics.README.md: AddedMetricssection and Table of Contents link pointing todocs/metrics.md.