Skip to content

ci(node.js): update workflow#138

Merged
75lb merged 1 commit into
75lb:masterfrom
Fdawgs:patch-1
Nov 18, 2024
Merged

ci(node.js): update workflow#138
75lb merged 1 commit into
75lb:masterfrom
Fdawgs:patch-1

Conversation

@Fdawgs
Copy link
Copy Markdown
Contributor

@Fdawgs Fdawgs commented Nov 18, 2024

This PR:

  • Removes Git credentials/SSH keys after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script
  • Declares the minimum permissions for the workflow to run at the job level, following principle of least privilege; see related GitHub security post

@75lb 75lb merged commit fdb7af8 into 75lb:master Nov 18, 2024
@75lb
Copy link
Copy Markdown
Owner

75lb commented Nov 18, 2024

thanks 👍

@Fdawgs Fdawgs deleted the patch-1 branch November 18, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants