Repository navigation
Say that PHP's start-up engine always uses MaxPerformance, and that Update Matched User Agent is on by default - #307
Draft
jwrosewell wants to merge 1 commit into
Draft
jwrosewell wants to merge 1 commit into
jwrosewell wants to merge 1 commit into
Conversation
The performance options page, the cloud to on-premise guide and the IP Intelligence algorithm page now say that the engine PHP builds when it starts, from the php.ini file, always uses MaxPerformance, and why. The IP Intelligence page also says that an engine PHP code builds later from a settings array defaults to Balanced. The match metadata section now says that UserAgents is filled in only when Update Matched User Agent is on, which it is by default.
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four pages state a default or a rule that the specifications changed or made explicit this week. This pull request brings them in line.
Hold this until the package releases have shipped. Two of the statements it adds are true only once releases that are not out yet have shipped, as set out under Releases this waits for.
What the specification now says
At specifications 4da1891 on rc:
UserAgentsmatch metric is filled in only when it is on (UserAgents row and Update Matched User Agent row).What changed on each page
Balancedas the default, with no exception.MaxPerformance, that any other profile set there is refused, and why.Balancedas the default.MaxPerformance, so there is no profile to choose in PHP, and links to the performance options page for the reason.Balanced.UserAgentsincluded, is returned "Regardless of the settings used".UserAgentsis filled in only when Update Matched User Agent is on, which it is by default. The opening sentence now names theDifferenceandDriftsettings, so the two sentences agree.Releases this waits for
The PHP Device Detection statements are true today. PHP 4.5.206 already builds the start-up Device Detection engine with MaxPerformance (hash-php.i lines 83 to 95) and refuses any other profile in the php.ini file (DeviceDetectionOnPremise.php lines 58 to 63).
The Balanced default these pages already state
The pages already said that Balanced is the default, and this pull request does not change that wording. It is wrong today in some languages and becomes right with the same releases.
ConfigIpidefault constructor (IPIntelligenceOnPremiseEngineBuilder.java line 67), which in C library 4.5.103 holds the data in memory (ConfigIpi.cpp lines 28 to 31). On the C library's rc branch that constructor starts from the default configuration, which is Balanced (ConfigIpi.cpp lines 30 to 32), and the C library release candidate is 51degrees-cxx#137.Recommendation
Wait for the releases, as #303 does, rather than name versions on the pages. Naming versions would need one for each language and builder above, and the Python Device Detection change is not in any release candidate yet, so the version that will carry it cannot be known. Mark this ready once the C library release and the next Node.js, Python, Java and PHP releases have shipped, after checking that the Python release carries #57.
Searches run
All on rc at 8529cbe, case-insensitive, across the Markdown in
src, the snippets insrc/snippets, the pattern library sources and the Doxygen files indocs:LowMemory,MaxPerformance,Balanced,PerformanceProfile,performance_profile,performance profile, anddefaultwithin 40 characters ofprofileUpdateMatchedUserAgent,update_matched_useragent,MatchedUserAgent,UserAgents,matched51dpipeline,endpoint,SetEndpoint,JavaScriptBuilder,callback urlObjectName,objName,object-name,object_name,fod-js,fodas a wordMissingTranslationBehaviour,MissingTranslationBehavior,sourceDataKey,SourceElementDataKey,translat,behavior,behaviourphp.ini,ini_set,FiftyOneDegreesHashEngine,FiftyOneDegreesIpmemoryHits left alone
performance_profile=LowMemoryin the php.ini file, which PHP 4.5.206 already refuses. Say what Concurrency does on the concurrent processing page #303 replaces that snippet, so this pull request leaves the page alone.DEFAULTSvalue.fodas the default object name, which has not changed.