Repository navigation
Fail the JSON Builder when no Sequence Element has produced a sequence number - #76
Draft
jwrosewell wants to merge 3 commits into
Draft
jwrosewell wants to merge 3 commits into
jwrosewell wants to merge 3 commits into
Conversation
The JSON Builder fails without a sequence number, so a pipeline without a Sequence Element no longer reaches the script. The builder's reading of text values stays covered by the get_sequence tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For specifications#80. The JSON Builder "MUST fail with an error and MUST NOT set its JSON" when no Sequence Element has produced a sequence number, and a
query.sequencevalue from a query string does not count.JSONBundlerElement.process_internaltreated a missing number as below the limit and built the JSON withjavascriptProperties, and compared text to 10, which raisesTypeError.What changed
jsonbundler.pyreadsquery.sequenceonce at the start. If it is not an integer (a text value or a boolean does not count) it raises, naming the Sequence Element, before any JSON is built. With suppressed errors the error is recorded and nojsonbundlerdata is set.test_javascriptbuilder_sequence.pybuilt pipelines with the JSON Builder and no Sequence Element, which can no longer produce a script. Those variants are removed, and the rest build on the default pipeline. The builder's reading of odd text values stays covered by theget_sequencetests, and the Sequence Element's own handling by the with-element variants.Overlap
The web integration draft #70 edits
test_javascriptbuilder_sequence.pyandjsonbundler.pytoo, in other lines. Whichever merges second needs a small rebase.How it was verified
New tests in
pipeline/fiftyone_pipeline_core/tests/test_jsonbundler_sequence_required.py.841d84c3: run 42705318801, 6 passed, core 325 passed.The last release into
mainmerged on 2026-11-04.