Skip to content

fix: improve Leads header contrast in dark mode #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Krisor1986 merged 1 commit into from
Oct 3, 2026
Merged

fix: improve Leads header contrast in dark mode #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/front/pages/Leads.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ export const Leads = () => {
<div className="card border-0 shadow-sm bg-white rounded-3 overflow-hidden">
<div className="table-responsive">
<table className="table align-middle mb-0">
<thead className="table-light text-secondary text-uppercase" style={{ fontSize: "0.72rem", letterSpacing: "0.5px" }}>
<thead className="table-light text-secondary text-uppercase leads-table-header" style={{ fontSize: "0.72rem", letterSpacing: "0.5px" }}>
<tr>
<th className="py-3 px-4">Nombre</th>
<th className="py-3">Origen</th>
Expand Down
11 changes: 11 additions & 0 deletions src/front/styles/leads.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,17 @@
box-shadow: 0 -8px 20px rgb(15 23 42 / 6%);
}

:root[data-bs-theme="dark"] .leads-table-header {
--bs-table-bg: var(--cf-surface-muted);
--bs-table-color: var(--cf-text);
--bs-table-border-color: var(--cf-border);
}

:root[data-bs-theme="dark"] .leads-table-header > tr > th {
color: var(--cf-text) !important;
background-color: var(--cf-surface-muted) !important;
}

@media (max-width: 767.98px) {
.lead-form-modal {
padding: 0;
Expand Down
9 changes: 9 additions & 0 deletions tests/frontend/productionQa.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ test("lead search icon has a centered fixed hit area", () => {
assert.match(leads, /minWidth: "2\.75rem"/);
});

test("lead table header remains readable in dark mode", () => {
const leads = source("src/front/pages/Leads.jsx");
const css = source("src/front/styles/leads.css");
assert.match(leads, /leads-table-header/);
assert.match(css, /data-bs-theme="dark"[^}]*\.leads-table-header/);
assert.match(css, /--bs-table-bg:\s*var\(--cf-surface-muted\)/);
assert.match(css, /--bs-table-color:\s*var\(--cf-text\)/);
});

test("job scheduling uses API field names without timezone shifts", () => {
const jobs = source("src/front/pages/Jobs.jsx");
const jobDetail = source("src/front/pages/JobDetail.jsx");
Expand Down
Loading