handle proxy option in Client constructor + change connections callback signature#23
Open
camfou wants to merge 1 commit into3scale-labs:masterfrom
Open
handle proxy option in Client constructor + change connections callback signature#23camfou wants to merge 1 commit into3scale-labs:masterfrom
camfou wants to merge 1 commit into3scale-labs:masterfrom
Conversation
… signature to handle 3Scale connection errors
Contributor
|
Thanks Camille! We will review and run the tests ourselves since we need to use a private key to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I suggest you this PR, to handle Client.prototype.*authorize connections errors and add the possibility to pass a proxy url in the Client constructor.
Regards,
Camille
PS : I wanted to update the tests but I cannot launch them, I got only provider_key and user_key