Remove farfetch-scraper leftovers from templates, TROUBLESHOOTING, SECURITY and diff_runs

[jehrr]

Leftovers from farfetch-scraper (the donor) that describe Farfetch as if it were Amazon. Amazon publishes no JSON-LD, so every "JSON-LD first" instruction here pointed a reader at a path that does not exist.

Fixed

• .github/ISSUE_TEMPLATE/bug_report.yml — "Zero products? … not the bare /shopping/kids/items.aspx hub — the hub carries no product JSON-LD" (Farfetch's hub), "See 'Geo-redirect' in the README" (no such section), --out girls, and "96 products, as the README says a category page yields". Now: open the {out}_page1_debug.html dump (TROUBLESHOOTING's own advice), the README's "currency follows the exit IP" trap (amazon.co.uk/.co.jp quoting EUR from a European exit), --out headphones, and the README's measured "16–30 organic tiles per search page".
• site_changed.yml — "the parser tries JSON-LD first, then a CSS + URL-pattern fallback" and a JSON-LD extraction one-liner / "paste one Product node from the ItemList". Now the data-attribute anchors from README "How it parses" and the /dp/{ASIN} fallback; evidence asks for --dump-html and whether the fallback warning fired.
• TROUBLESHOOTING.md — 0-rows table: "The JSON-LD path found nothing… Check that product links still match -item-<digits>.aspx" and "The hub URL. /shopping/kids/items.aspx…". First row rewritten to Amazon's anchors and fallback; the hub row removed (no Amazon equivalent measured in this repo).
• SECURITY.md — "how Akamai or reCAPTCHA behave" → "how AWS WAF or Amazon's own captcha behave" (README: AWS WAF, not Akamai).
• diff_runs.py docstring — source_changed explained as "the DOM-corrected figure and the raw JSON-LD one" → the offscreen/split/detail nodes this repo's price_source records; examples used Farfetch's girls_clothing → headphones.
• CONTRIBUTING.md — "the registration form" (Farfetch's reCAPTCHA target) → "a registration or login form".

Kept, deliberately

• product_parser.py "Every other scraper in this family reads schema.org JSON-LD first…" — family provenance explaining why this repo differs. (Borderline: no longer true of every sibling, but it is not a donor description of this site.)
• farfetch notes in captcha_solver.py, craigslist note in .gitignore — explicit sibling provenance.
• README badges: already 7, in family order; "runs without an account" is honest (README "What works with nothing at all": 77 products over 3 pages with no key, proxy or account, 2026-09-08).
• Repo description/topics: no donor words, unchanged. Released CHANGELOG sections untouched; the bullet is added to the existing [Unreleased] → Fixed.
• The main checkout's untracked .claude/ and the audit-stage1 worktree were not touched.

Verification

python3 smoke_test.py exit 0 before and after (same two engine groups skipped locally); ci_checks.py --secret-check exit 0; issue templates parse as YAML.

🤖 Generated with Claude Code