feat: add convert-video, shared bootstrap, common lib, fix sast brew bug#10
Merged
Conversation
- Add bin/_bootstrap: single location for symlink-crawl and CLI_TOOL_ROOT export - All bin scripts source _bootstrap instead of inlining the while loop - Extract gecho/show_progress/color vars into lib/common.sh - Add bin/convert-video and lib/ffmpegcmds.sh for H.264/AAC MP4 conversion - Fix sast defaulting PLUGINS_DIR to script install path (broke brew installs) - Add tests for _bootstrap and common.sh; fix test_gitcmds and test_sast for new structure - Update README structure section and add convert-video docs Closes #9 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/_bootstrap— symlink-crawl andCLI_TOOL_ROOTexport extracted into one file; all bin scripts source it viasource "${BASH_SOURCE[0]%/*}/_bootstrap"instead of inlining the while looplib/common.sh—gecho,show_progress, and ANSI color vars moved out ofgitcmds.shinto a shared libbin/convert-video+lib/ffmpegcmds.sh— new command: converts video to H.264/AAC MP4 via ffmpegsastbrew bug fix —PLUGINS_DIRwas defaulting to the script's install path ($REPO_ROOT/plugins), which doesn't exist in brew installs; now defaults to$(pwd)/plugins(closes [Bug] sast does not work when installed from homebrew #9)_bootstrapandcommon.sh; existingtest_gitcmdsandtest_sastupdated for the new structure; 40/40 passingTest plan
make lint— passes cleanmake test— 40/40 passingbrew installand rungitprune,gitrefresh,sastfrom outside the repo to verify brew paths resolve correctlyconvert-videowith a real video filesastrun from a project root with aplugins/dir (no arg) and with an explicit path arg🤖 Generated with Claude Code