Repository navigation
G01: pin Go 1.26.9 and publish completed offline verification - #105
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Codex gpt-6.1-sol / medium review APPROVED exact 4ba3a1b vs main 9a82a6a (Orca task_38dba6b7798c / ctx_e94d28388fbf). No actionable contract/security findings. Confirmed consistent pins and preserved admission predicates, exact-source evidence reuse, historical RED attribution/failures, read-only hosted workflow permissions, local links and diff/private-path/secret-pattern checks. No suites were redundantly rerun; no live actions. Same-head PR quick check succeeded: https://github.com/1XP-AI/gh-runnerd/actions/runs/39756185564 . GitHub Codex review is still running; not merge approval yet. A focused additional independent security pass is being requested for the shared admission boundary. G01 live and production acceptance remains HOLD. |
|
Final security second pass APPROVED exact 4ba3a1b (independent Codex gpt-6.1-sol / medium; task_9a165e89908a / ctx_e7525daa1fce). No findings: previous/newer/missing BuildInfo refused; clean revision, SDK/no-replace, tag/platform/cgo restrictions preserved; controller quarantine and provenance/conditional-delete boundaries unchanged; no CI authority expansion. Static diff hygiene passed; no dynamic probes or redundant suite. This supplements the first independent contract review above. GitHub Codex summary #105 (comment) reports code_review completed at this exact SHA, has_any_findings=false and has_unresolved_findings=false. Both inline and review-body APIs are empty; no findings to defer. Hosted quick run39756185564 succeeded for the same SHA. Merge is limited to offline pin/evidence changes; G01 closure and live execution remain unauthorized. |
|
Merged exact reviewed candidate as main 3255cf3. Postmerge Public CI https://github.com/1XP-AI/gh-runnerd/actions/runs/39756836061 completed SUCCESS: root/tooling, root race, G01/G02/R1 offline modules, vulnerability check and aggregate gate all passed. This is integration evidence, not live qualification; issue #1 remains open and Project In progress. Local main fast-forwarded cleanly. |
Scope
Refs #1; does not close G01.
Actual validation and limitations
Still open / rollback
No canary run, JIT issuance, worker/Scale Set mutation or production gate completion. Existing private workflow is not the nonce-bound Linux workload; broker provenance, trust-root provisioning and conditional cleanup remain unresolved.
#79 / PR #103 owns packet scanner/profile work separately; its eight outstanding P1s are being corrected and are not claimed resolved here.
Rollback is a reviewed revert of this bounded pin/evidence change; reverting the security patch reopens its documented vulnerability gap. Preserve existing runners and historical evidence.