Skip to content

fix: fix SSH service auto-enable issue #12898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 1 commit into from
May 29, 2026
+1 −1
Merged

fix: fix SSH service auto-enable issue #12898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent/app/service/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func (u *SSHService) OperateSSH(operation string) error {
return err
}
} else {
if err := disableSSHSocket(serviceName, false); err != nil {
if err := disableSSHSocket(serviceName, true); err != nil {
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the active socket when toggling autostart

When a host is using socket-activated SSH (ssh.socket/sshd.socket active while the service itself is inactive), the Auto start switch now stops the only active listener and then only runs systemctl enable ...service. systemctl --help distinguishes start as "Start (activate)" under Unit Commands from enable as "Enable one or more unit files" under Unit File Commands, so this path can leave SSH unreachable until the service is started or the host reboots; the frontend switch is labeled Auto start and sends enable/disable, so users would not expect it to stop current SSH access.

Useful? React with 👍 / 👎.

return err
}
if err := controller.Handle("enable", serviceName+".service"); err != nil {
Expand Down
Loading