feat: Modify the Gemini account verification logic#12155
feat: Modify the Gemini account verification logic#12155f2c-ci-robot[bot] merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eaa9ad8889
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| request.URL = base + "/models/gemini-3-flash-preview:generateContent" | ||
| } else { | ||
| request.URL = fmt.Sprintf("%s/v1beta/models?key=%s", base, apiKey) | ||
| request.URL = base + "/v1beta/models/gemini-3-flash-preview:generateContent" |
There was a problem hiding this comment.
This verification flow hard-codes gemini-3-flash-preview as the probe model, so keys that are valid but lack access to that preview SKU (while still being usable with supported catalog models like google/gemini-flash-latest) will fail verification with 403/404 and be rejected during account create/update.
Useful? React with 👍 / 👎.
| func buildGeminiPatch(modelName string) *OpenClawPatch { | ||
| return &OpenClawPatch{PrimaryModel: modelName} |
There was a problem hiding this comment.
This Gemini patch no longer includes Models, and writeOpenclawConfig only rewrites conf["models"] when patch.Models is non-nil. For upgraded agents that already have models.providers.google from the previous behavior, changing Gemini accounts now leaves stale API/baseURL values in openclaw.json, so runtime credentials can remain out of sync with the selected account.
Useful? React with 👍 / 👎.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Refs #12149