feat: refactor image update flow and align i18n messages#12154
feat: refactor image update flow and align i18n messages#12154f2c-ci-robot[bot] merged 1 commit intodev-v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ssongliu
changed the title
ssongliu
force-pushed
the
feat/image-update-flow-i18n
branch
from
e84a16b to
ed999e9
Compare
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e84a16b592
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const taskID = newUUID(); | ||
| await imagePull({ | ||
| taskID: taskID, | ||
| repoID: 0, |
There was a problem hiding this comment.
The update flow always sends repoID: 0, which bypasses configured image-repo credentials and forces an unauthenticated pull path. This breaks updates for tags hosted on private registries (or any registry that depends on saved repo auth), even though normal pull flow explicitly captures and submits repoID for that purpose (frontend/src/views/container/image/pull/index.vue). As a result, the new update action can fail for the exact images users most need to refresh.
Useful? React with 👍 / 👎.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Refs #10786